Feature/youtube buttons#2388
Open
bwhalley wants to merge 5 commits into
Open
Conversation
Add optional bottom YouTube bar (setting subPanelYouTube) with prev, play/pause, next, and tab mute. Targets audible YouTube watch/shorts/ youtu.be tabs, or paused tabs after Sidebery media control. Uses existing play/pause media injections and executeScript for YTP buttons. Dock layout preserves bottom bar spacing in tab panels. Made-with: Cursor
…ttom bar Use tab.url with URL() host/path checks (m.youtube, music, live, embed). Subscribe to reactive.active for Vue updates. Prefer audible, then Sidebery- paused, then active playback URL for muted/delayed audible. Move YouTube dock above BottomBar; override flex so controls stay on one row. Made-with: Cursor
Poll browser.tabs.query(audible) on tab events and interval; prefer that tab id over Sidebery heuristics. Fall back to active window tab on playback URLs. Register listeners after Tabs.load; wrap state with reactivate(). Replace rotated arrow-down with chevron-left/right SVG sprites. Made-with: Cursor
Remove no_playing copy and hint block; simplify youtube.fg comments and log lines, unexport tabUrl, reuse onActivated handler for probe, 3s poll. Made-with: Cursor
Made-with: Cursor
Contributor
|
looking forward to this one! some things I'd love to see in the future for this:
|
| 'bar.youtube.mute': { | ||
| en: 'Mute tab', | ||
| de: 'Tab stummschalten', | ||
| fr: 'Couper le son de l’onglet', |
Contributor
There was a problem hiding this comment.
Using YouTube's own translations would be much better for correctness and consistency.
Picking this one just as an example. YouTube's translation is "Désactiver le son". The addition of de l'onglet is a separate decision, which might be worth discussing as well.
Missing languages should be easy to add too, but I'm not sure what the Chinese ones correspond to on YouTube's language list which has Simplified, Traditional, and Hong Kong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in a discussion thread. Adds a basic YouTube player interface to the bottom of the panel bar. The bar is defaulted off and controlled through a settings panel. I included a best try at some basic translations for the new UI elements. I tried to keep the code as tight as possible here, while supporting a range of YouTube player URLs.
This could also be easily extended to any media player instead.